Lesson 17 assignment problem

[Psychoman]

Hello, I have a problem with L17 homework.The problem is if I run the program normal it randoms some kind of number and later all numbers are the same ( f.e. roll 5 dice : 1,1,1,1,1 ), something like that.But if I am trying to debug the program it works just fine and this makes me anxious.I just get a feeling that something is wrong with pointers .

Code: Select all

int StrToInt( const char* InputStr )
{
	int maxLen = 0;
	int number = 0;
	for( ;*InputStr != '\0' ;InputStr++ )
	{
		maxLen++;
	}
        //Point on the last element
	InputStr--;
	for( int i = 0; i < maxLen ;InputStr--,i++ )
	{
		if( *InputStr < 57 || *InputStr > 48 && *InputStr!= '\0' )
		{
			char temp = *InputStr;
                        // -48 - change from char to int
                        // pow is for f.e 123 = 100*1 + 10*2 + 1*3
			number += ( temp - 48 )*pow( (float) 10,i );
		}
		else 
		{
			continue;
		}
	}
	return number;
}

void IntToStr( int num,char* buf,int buflen )
{
	for( int i = buflen;i>=0;i--,buf++ )
	{
                // leaves first number
		int temp = num / pow( (float) 10, i );
		// minuses this first number f.e. 123  - 100 = 23
                num -= temp * pow( (float) 10, i );
		//Changes to character
                *buf = temp + 48;
	}
	*buf = '\0';
}
void main()
{
	char mes[] = "Enter how many dices to roll: ";
	const int lengthNumber = 4;
	char NumberRolles[lengthNumber];
	
	GetString( NumberRolles, lengthNumber );
	
	PutString( mes );
	PutString( NumberRolles );
	PutString( "\n" );
        PutString( "Dice numbers: \n" );

        const int numbRolles = StrToInt( NumberRolles );
	char StrDice[2];
	int sum = 0;
	char DisplaySum [4];
	for( int i = 0;i<numbRolles;i++ )
	{
		srand( (unsigned int) time( NULL ) );
		int temp =  rand() % 6 + 1;
		sum += temp;
		IntToStr(temp ,StrDice, 0 );
		
		PutString( StrDice );
		PutString( " " );
	}
		
	IntToStr( sum ,DisplaySum, 2 );

	PutString( "\n" );
	PutString( "Total Sum is: " );
	PutString( DisplaySum );
	PutString( "\n" );
}

[LuisR14]

why you using srand every run of the for loop?, it should just be used at the start of main()

[Psychoman]

I want to go kill myself , such .... I debugged it for 20 min.I got it why random does the same number every time.

[LuisR14]

well when you're debugging the time elapsed is greater so srand gives off different rand numbers, but when you're not debugging it runs at a fraction of a second (too fast for the rand generator to notice since time() returns about the same value for the rand generator)

[Psychoman]

Yeap thx I thought of that)