Infinite jumping

[lori3]

Hey. I tried to make a super mario - copy for myself in chilli framework, and after a few minutes of development i ran into a few errors. These files show how the mario object is animated to jump.
Can this be fixed somehow?

[Zedtho]

With infinite jumping, do you mean that you can double jump and stuff or do you mean that Mario is jumping whenever it hits the ground.

I needed similar physics a week ago, I'll send them here:

Code: Select all

BallY = BallY + BallVY;
		++BallVY;
		
		if (BallY >= (gfx.ScreenHeight - 1 - BallHeight))
		{
			BallVY = 1;
			SpaceBarWasPressed = false;
		}
		if (wnd.kbd.KeyIsPressed(VK_SPACE) && !SpaceBarWasPressed)
		{
			BallVY = BallVY - 20;
			SpaceBarWasPressed = true;
		}
		if (BallY <= 0)
		{
			BallVY = 1;

		}
		BallX = ClampScreenX(BallX, BallWidth);
		BallY = ClampScreenY(BallY, BallHeight);

I'll continue looking at this, though.

Also, use { } with your if statement, although you're only executing one thing after the if statement. Because if one adds things one will often forget to add the parameters.

If I were to debug this I'd think the error is in the
if(y <= (Graphics::Screenheight - Groundheight - 400)

[lori3]

I mean that the animation is executed properly, but when mario touches the ground it bounces back infinitely.

The line you pointed out is just supposed to set the height the guy jumps to..

[Zedtho]

I don't see Mario being pulled back to the ground with a y += 10; or something anywhere, so it might get stuck at it's maximum height. Sorry, but I can't say much with this little code shown.

I apologise for the mistake with the if statement, by the way. Kind of stupid of me, haha.

[lori3]

This code makes it fall if not touching the ground.Forgot to share it sorry.

[Zedtho]

Hmm, I guess more experienced programmers should get a go at this, then.
If you could post the whole code to the forum (via github or by attaching file after having zipped it with the tool by Chili) I could probably figure it out, though.

[chili]

Yes, always post full code.